fix: metrics fields in wrong order #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #611 +/- ##
=======================================
Coverage 82.47% 82.47%
=======================================
Files 26 26
Lines 2123 2123
=======================================
Hits 1751 1751
Misses 288 288
Partials 84 84 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
johnbieren
approved these changes
Nov 19, 2024
theflockers
force-pushed
the
fix_metrics
branch
from
55ad602 to
5a77363
Compare
|
New changes are detected. LGTM label has been removed. |
|
/retest |
theflockers
force-pushed
the
fix_metrics
branch
from
5a77363 to
dd806ef
Compare
this commit fixes the order which the metrics parameters are sent, causing wrong data being sent. Signed-off-by: Leandro Mendes <[email protected]>
theflockers
force-pushed
the
fix_metrics
branch
from
dd806ef to
02324c1
Compare
|
/retest |
1 similar comment
|
/retest |
theflockers
added a commit
to theflockers/infra-deployments
that referenced
this pull request
Nov 21, 2024
this commit updates the release-service on the stage cluster Included PRs: - konflux-ci/release-service#614 - konflux-ci/release-service#611 Signed-off-by: Leandro Mendes <[email protected]>
theflockers
added a commit
to theflockers/infra-deployments
that referenced
this pull request
Nov 21, 2024
this commit updates the release-service on the prod cluster Included PRs: - konflux-ci/release-service#614 - konflux-ci/release-service#611 Signed-off-by: Leandro Mendes <[email protected]>
openshift-merge-bot bot
pushed a commit
to redhat-appstudio/infra-deployments
that referenced
this pull request
Nov 21, 2024
this commit updates the release-service on the stage cluster Included PRs: - konflux-ci/release-service#614 - konflux-ci/release-service#611 Signed-off-by: Leandro Mendes <[email protected]>
openshift-merge-bot bot
pushed a commit
to redhat-appstudio/infra-deployments
that referenced
this pull request
Nov 21, 2024
this commit updates the release-service on the prod cluster Included PRs: - konflux-ci/release-service#614 - konflux-ci/release-service#611 Signed-off-by: Leandro Mendes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit fixes the order which the metrics
parameters are sent, causing wrong data being
sent
Signed-off-by: Leandro Mendes [email protected]